Fix alpine image to 3.19.0 #5454

prakrit55 · 2024-05-15T18:39:36Z

Which problem is this PR solving?

Description of the changes

changed alpine image tag from 3.16 to 3.19.0

How was this change tested?

Checklist

I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
I have signed all commits
I have added unit tests for the new functionality
I have run lint and test steps successfully
- for jaeger: make lint test
- for jaeger-ui: yarn lint and yarn test

remove root_image and cert_image and all the references Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>

add Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>

fix alpine version to 3.19.0 Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>

docker/Makefile

codecov · 2024-05-15T18:56:38Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.46%. Comparing base (afd39dd) to head (3299b00).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5454   +/-   ##
=======================================
  Coverage   95.46%   95.46%           
=======================================
  Files         331      331           
  Lines       16113    16113           
=======================================
  Hits        15383    15383           
  Misses        556      556           
  Partials      174      174

Flag	Coverage Δ
badger_v1	`8.07% <ø> (ø)`
cassandra-3.x-v1	`16.48% <ø> (ø)`
cassandra-3.x-v2	`1.86% <ø> (ø)`
cassandra-4.x-v1	`16.48% <ø> (ø)`
cassandra-4.x-v2	`1.86% <ø> (ø)`
elasticsearch-7.x	`1.78% <ø> (ø)`
elasticsearch-8.x	`1.78% <ø> (ø)`
grpc_v1	`9.12% <ø> (ø)`
grpc_v2	`7.48% <ø> (-0.02%)`	⬇️
kafka	`9.81% <ø> (ø)`
opensearch-1.x	`1.77% <ø> (-0.02%)`	⬇️
opensearch-2.x	`1.78% <ø> (+0.01%)`	⬆️
unittests	`93.98% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

add Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>

yurishkuro · 2024-05-15T20:20:34Z

Probably need to make a fix to ./scripts/check-go-version.sh to pass the linter. The script is currently checking the Makefile:

check docker/Makefile "^.*golang:$version_regex" "$go_latest_version"

Instead it should be pointed to check the Docker file docker/base/Dockerfile

fixed lint errors Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>

fix Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>

prakrit55 · 2024-05-16T02:03:18Z

Probably need to make a fix to ./scripts/check-go-version.sh to pass the linter. The script is currently checking the Makefile:
check docker/Makefile "^.*golang:$version_regex" "$go_latest_version"
Instead it should be pointed to check the Docker file docker/base/Dockerfile

I think it should point to the Dockerfile in the debug

yurishkuro · 2024-05-16T02:34:35Z

Thanks!

yurishkuro · 2024-05-20T05:23:26Z

docker/base/Dockerfile

-ARG cert_image
-ARG root_image
+ARG cert_image=alpine:3.19.0
+ARG root_image=alpine:3.19.0


dependabot doesn't seem to be able to handle this, it did not raise a PR to upgrade to 3.19.1

I think we need to remove these args altogether and define versions directly in the FROM directive. That dependabot should definitely support.

prakrit55 added 3 commits May 16, 2024 00:06

Update Makefile

3570f0b

remove root_image and cert_image and all the references Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>

Update Makefile

44b068c

add Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>

Update Dockerfile

3721805

fix alpine version to 3.19.0 Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>

prakrit55 requested a review from a team as a code owner May 15, 2024 18:39

prakrit55 requested a review from joe-elliott May 15, 2024 18:39

yurishkuro reviewed May 15, 2024

View reviewed changes

docker/Makefile Show resolved Hide resolved

prakrit55 added 2 commits May 16, 2024 00:27

Update Makefile

e34f3d0

add Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>

Update Dockerfile

7f76b24

add Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>

yurishkuro approved these changes May 15, 2024

View reviewed changes

yurishkuro added the changelog:bugfix-or-minor-feature label May 15, 2024

prakrit55 added 2 commits May 16, 2024 07:22

Update check-go-version.sh

bfba358

fixed lint errors Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>

Update check-go-version.sh

3299b00

fix Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>

yurishkuro approved these changes May 16, 2024

View reviewed changes

yurishkuro merged commit 5554e34 into jaegertracing:main May 16, 2024
37 of 38 checks passed

yurishkuro reviewed May 20, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix alpine image to 3.19.0 #5454

Fix alpine image to 3.19.0 #5454

prakrit55 commented May 15, 2024

codecov bot commented May 15, 2024 •

edited

Loading

yurishkuro commented May 15, 2024

prakrit55 commented May 16, 2024

yurishkuro commented May 16, 2024

yurishkuro May 20, 2024

Fix alpine image to 3.19.0 #5454

Fix alpine image to 3.19.0 #5454

Conversation

prakrit55 commented May 15, 2024

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

codecov bot commented May 15, 2024 • edited Loading

Codecov Report

yurishkuro commented May 15, 2024

prakrit55 commented May 16, 2024

yurishkuro commented May 16, 2024

yurishkuro May 20, 2024

Choose a reason for hiding this comment

codecov bot commented May 15, 2024 •

edited

Loading